Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify mismatched code comments in podbindingcontroller #1928

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

huangchenzhao
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

modify mismatched code comments in podbindingcontroller

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81d21b7) 52.16% compared to head (474b61b) 52.17%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1928   +/-   ##
=======================================
  Coverage   52.16%   52.17%           
=======================================
  Files         172      172           
  Lines       20874    20874           
=======================================
+ Hits        10888    10890    +2     
+ Misses       9018     9017    -1     
+ Partials      968      967    -1     
Flag Coverage Δ
unittests 52.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

/rerun

3 similar comments
@rambohe-ch
Copy link
Member

/rerun

@huangchenzhao
Copy link
Member Author

/rerun

@huangchenzhao
Copy link
Member Author

/rerun

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Jan 23, 2024
@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch merged commit 5676567 into openyurtio:master Jan 23, 2024
13 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants